Patch Set 1: Code-Review-1
Please don't. This breaks git blame and IMO makes the file harder to read.
None of the meson files use tabs, and I'd rather have a mixed tabs/spaces style there.
Well, git blame on this rather recent part of the code isn't too critical. What about the reordering of flashchips.c, which also broke git blame? In any case, one can checkout the parent of the offending commit and run git blame on that.
With regard to tabs, would this be better if done with spaces instead? It would make the lines shorter.
View Change
To view, visit change 38662. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf0881859416e3d824228a0f78447da0bf8604b2
Gerrit-Change-Number: 38662
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:37:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment