View Change

2 comments:

• File cli_classic.c:

  • Patch Set #19, Line 619: fill_flash->chip->total_size * 1024

    *nod* […]

    I would go for flash_size(), keep things simple:

      static inline size_t flash_size(const struct flashctx *);

• File fmap.c:

  • Patch Set #19, Line 62: if (i == FMAP_STRLEN - 1) {

    I suspect the intention here is to say that if we reach FMAP_STRLEN - 1 without quitting due to the […]

    What I meant was that I'd have written a similar condition below
    the loop. A common pattern, FWIW, for-loop + check if it run all
    the way through.

    But you are right, just leave it as is.

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.