Attention is currently required from: Angel Pons, Anastasia Klimchuk.

Patch set 4:Code-Review +2

View Change

1 comment:

• File dediprog.c:

  • Patch Set #3, Line 221: const int finish,

    I used "at least after the opening parenthesis" option. […]

    I don't think there is a written rule. There are three common ways
    to indent parameter lists, I think, by decreasing popularity (by my
    own perception):

     /* Aligned right after the opening parenthesis */
     void some_function(int some_param,
    		    int another_param)

     /* All aligned to two tabs */
     void function_with_a_long_name_that_leaves_little_space(
    		int some_param,
    		int another_param)

     /* Aligned after the opening parenthesis, with tabs only */
     void some_function(int some_param,
    			int another_param)

    I'd say for review, it just shouldn't look obviously wrong. To me,
    dediprog_read() still does.

    If I had to extract a rule from the most common practice it would
    be this: All parameter declarations should be aligned to the
    same column, but never with the function body (hence the two
    tabs in the second example and not just one). That would apply
    to the first two examples above.

To view, visit change 56414. To unsubscribe, or for help writing mail filters, visit settings.