Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.

Patch set 6:Code-Review +1

1 comment:

Patchset:
- Patch Set #6:
  David, thank you for the patch! I have a question. […]
  Hello! good points,
  When someone enables 'pullups=on', the internal pull-ups are activated (powered from a VPU input pin), making the MOSI, MISO, etc., pins function as an open collector (hi-z) using these pull-ups.
  Therefore, 'pullups=on' inherently works as an open collector. Thus, setting both 'pullups=on' and 'hiz=on' is redundant but not incorrect.
  However, considering human error, I'm unsure if we should flag this as an error.
  What do you think? Would you like me to commit this change?
  BUT! A common and dangerous mistake is when people incorrectly use 'pullups' arg: 'pullups=1' or 'pullups=enable'. In such cases, flashrom continues to run without using the pull-ups or open collector, sending 3.3V through the SPI pins, which can damage 1.8V or 2.5V chips.
  Therefore, I believe if we detect a syntax error in 'pullups=' or 'hiz=', we should flag an error and not continue running flashrom. Would you like me to commit this change?

To view, visit change 79299. To unsubscribe, or for help writing mail filters, visit settings.