View Change
2 comments:
File dmi.c:
Patch Set #3, Line 23: #define _GNU_SOURCE
is there a downside to setting this explicitly in the build system?
I originally did however it is a little too big of a net to say everything is GNU C which it isn't.
Patch Set #3, Line 26: #define _POSIX_C_SOURCE 200809L
isn't this set explicitly now?
Yes it is, although I left dmi.c to be self-contained as it looks like it could be used in other places.
To view, visit change 47908. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4f973927fc018510a3beaa6c4fa2f356c77c7a6e
Gerrit-Change-Number: 47908
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Idwer Vollering <vidwer@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 11 Jan 2021 23:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-MessageType: comment