Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #1, Line 35:

    #if CONFIG_DUMMY == 1
    void dummy_init_and_shutdown_test_success(void **state)
    {
    	run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
    }
    #endif /* CONFIG_DUMMY */
    

    Thank you for inspiration! now this looks much better, and only one file needs to have guards. […]

    Hmmm, this will change with Thomas' patch series. Instead of the enums
    we'd have references to the programmer structs. Maybe we'd have to
    enable linker garbage collection*, but then a C `if` should do.

    (*) I wouldn't want such advanced linker features for the flashrom
    program yet but for tests I see no reason to avoid it.

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.