Attention is currently required from: Jonathan Zhang.
View Change
1 comment:
File chipset_enable.c:
Patch Set #3, Line 2076: enable_flash_c620
> Looking at the EDS (606161, rev 1.3), it seems closer to 300 series. […]
Took a look at a recent EBG datasheet and there are 16 FREGs in MMIO, however the last 4 are not contiguous with the first 12. Haven't had time to check the 300-series datasheet to see if it's the same.
Also, I noticed that newer EBG SPI programming guides now say SW sequencing is no longer supported (older versions said it *was* supported).
To view, visit change 54965. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e
Gerrit-Change-Number: 54965
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9@fb.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Comment-Date: Mon, 17 Jan 2022 04:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Jonathan Zhang <jonzhang@fb.com>
Comment-In-Reply-To: David Hendricks
Gerrit-MessageType: comment