Attention is currently required from: Thomas Walker.

View Change

3 comments:

• File flashchips.c:

  • Patch Set #5, Line 16387: FEATURE_4BA

    I see no mention of EAR (extended address register) in the datasheet, so that should be

        FEATURE_4BA_ENTER | FEATURE_4BA_NATIVE

    i.e. excluding FEATURE_4BA_EXT_ADDR

    The problem with these big chips and their 4-byte addresses is that there are usually
    at least 3 different ways to do it and that makes things harder to test.

  • Patch Set #5, Line 16387: .feature_bits = FEATURE_WRSR_WREN | FEATURE_4BA,

    Could add FEATURE_OTP.

• File spi25.c:

  • Patch Set #5, Line 492: true

    Looks like we grouped the 4BA commands at the end. Not sure if it matters, though.

To view, visit change 52310. To unsubscribe, or for help writing mail filters, visit settings.