View Change

2 comments:

• File libflashrom.c:

  • Patch Set #19, Line 468: (offset != 0)

    means you check offset == 0 quite often if rom_offset is 0, could this not be checked once?

  • Patch Set #19, Line 473: break

    Since this does not bail out on the stride loop we might as well use continue instead of break? if we continue this covers for instance Intel targets with locked regions.

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.