I think we can simplify that and just check protocol(). Does that sound right, Nico?
Patch set 2:Code-Review -1
View Change
1 comment:
File dediprog.c:
Patch Set #1, Line 1137: (dediprog_devicetype == DEV_SF600 || dediprog_devicetype == DEV_SF100) &&
Checking the devicetype seems kind of pointless, I think. The protocol() check should be sufficient.
To view, visit change 33195. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8822b79f46876feff0fd443f711c57dffb67b349
Gerrit-Change-Number: 33195
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Tue, 04 Jun 2019 10:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment