Attention is currently required from: Nikolai Artemiev, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #1, Line 1360:

    /* make sure HSFC register is cleared before initiate any operation */
    	REGWRITE16(ICH9_REG_HSFC, 0);
    
    	/* Set up transaction parameters. */
    	hsfc = REGREAD16(ICH9_REG_HSFC);
    

    Couldn't this be simplified?

    Something like this ?

    uint16_t hsfc = 0;

    hsfc |= hsfc_cycle;
    hsfc |= HSFC_FDBC_VAL(len - 1);
    hsfc |= HSFC_FGO; /* start */
    prettyprint_ich9_reg_hsfc(hsfc, ich_generation);
    REGWRITE16(ICH9_REG_HSFC, hsfc);

    Please refer to the latest patchset.
    Thanks for the suggestion.

To view, visit change 69788. To unsubscribe, or for help writing mail filters, visit settings.