Attention is currently required from: Anastasia Klimchuk.

View Change

6 comments:

• File linux_spi.c:

  • Patch Set #3, Line 111: const

    Why drop it?

    Ah, I've seen how it's used below now. Seems to counteract
    the idea of reentrant, though, doesn't it?

    I know you have plans to change the API, so it doesn't really
    matter now.

  • Patch Set #3, Line 71: (struct linux_spi_data *)

    Nit, generally no need to cast `void *` to anything.

  • Patch Set #3, Line 72: if (spi_data->fd != -1)

    Seems impossible to fail?

  • Patch Set #3, Line 177: -1

    Where would this be consumed?

  • Patch Set #3, Line 242: ret = SPI_GENERIC_ERROR;

    FWIW, this and the related definitions are part of the SPI command
    API and not for initialization.

  • Patch Set #3, Line 260: fd = -1;

    It's a local variable now, making this dead code.

To view, visit change 52285. To unsubscribe, or for help writing mail filters, visit settings.