Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.

Patch set 1:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I couldn't figure out whether this got here for a good reason. It seems to have been added about 13 years ago, to read, write, and erase paths -- which were all separate at the time.

    ```
    commit 1ee293ca95b62813a5208eb2f57fb9dbd6648c70
    Author: snelson <snelson@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1>
    Date: Fri Feb 19 00:52:10 2010 +0000

        Here's a very quick patch to fix the missing unlock code.
        Fixes missing unlock for certain chips:
         * unlock_49lf00x
            * Pm49fl002
            * Pm49fl004
        
         * unlock_49flxxxc
            * SST49LF160C
        
         * unlock_winbond_fwhub
            * W39V080FA
            * W39V080FA (dual mode)
        
        Fixes missing printlock for certain chip:
         * printlock_w39v040c
            * W39V040C
        
        
        Signed-off-by: Sean Nelson <audiohacked@gmail.com>
        Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
        
        
        
        git-svn-id: svn://coreboot.org/flashrom/trunk@907 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
    ```

    I also don't know how to validate your claim that flashrom doesn't implement these read-unlock operations at all.

    But I'm wholeheartedly in favor of the concept.

To view, visit change 75991. To unsubscribe, or for help writing mail filters, visit settings.