Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
View Change
1 comment:
File rayer_spi.c:
Patch Set #1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0)
The three steps seem reasonable, but i) and ii) seem to be in inverse order. […]
You are correct, great insight Angel. Can we spawn a bug so this doesn't get lost? I will abandon this commit.
To view, visit change 68231. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc
Gerrit-Change-Number: 68231
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 09 Oct 2022 01:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment