Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
1 comment:
File tests/init_shutdown.c:
Thanks so much for explanations! Things are now more clear in my head.
If we want to use Meson for the tests, it might be better if
somebody took over maintenance for it right now.
Yes. This can be me! (unless someone else disagrees)
I fully agree warning options should be the same. I created an experiment CB:58561. It does not build of course, because it uncovered a hundred of warnings, and they are treated as errors. I need to gradually fix all those warning in separate patches, it will take a while, but CB:58561 is convenient way to describe what I am thinking.
The `Makefile` also has a switch `WARNERROR` that defaults to `yes`. We
could have something similar for the tests that may default to `no` if
you prefer but would be enable by `test_build.sh` for the CI?
I thought about it, and I thought it's better to treat warnings as errors by default, same way as makefile is doing (less error-prone). I can disable the flag locally if needed.
It's really good this topic came up.
Speaking about this patch (raiden test), let me know if there is anything else to do. I am brewing something interesting for init-shutdown! :) but I want to have this one be completed/merged first.
To view, visit change 57918. To unsubscribe, or for help writing mail filters, visit settings.