TLRD; I don't think this is needed.

Please look into old patches more carefully, especially if their
commit message doesn't state what the change is about. Generally,
I wouldn't reject this change per se. But it would need a commit
message that makes sense in the history of the branch it is pushed
to.

In this case, it seems the original problem was already solved in
different ways upstream. So a commit on either side (upstream/
downstream) should state that its for alignment of the branches.
e.g.

    ichspi: Replace default JEDEC_BE_D8 with JEDEC_SE
    This aligns the upstream master branch with chromium's. Both
branches support on-the-fly opcode reprogramming by now, so
it shouldn't matter which opcode is the default.

Or the other way around for a commit to the downstream branch.

NB. In my limited experience with porting things over the years
over from chromium to upstream, it almost never made sense to
take the downstream commits as is because of the loss of context.
Unless the commits introduced completely new code, of course. It
might be better to pick topics, gather the code changes and write
new commits. Though, even that can be slower compared to a clean
reimplementation of the topic for upstream.

Patch set 1:Code-Review -1

View Change

1 comment:

To view, visit change 34689. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I379549e8fa966e75e3d8b7932700df62cf50df64
Gerrit-Change-Number: 34689
Gerrit-PatchSet: 1
Gerrit-Owner: Mayur Panchal <panchalm@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 05 Aug 2019 08:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment