David Hendricks posted comments on this change.
Patch set 1:Code-Review +2
The Lewisburg datasheet seems to indicate that SCGO is RW, and I'm not aware of any C62x variants where that use a different datasheet. So I think we're safe there.
However, I haven't tested swseq on Lewisburg since, as you suggested, I don't have one with an unlocked/non-zero opmenu at the moment. Flashrom sees the missing opcodes and falls back to hwseq on my test system.
(1 comment)
Would it make sense to move this to line 1800, closer to where ich_spi_mode gets set (near the beginning of case CHIPSET_ICH8)?
To view, visit change 22274. To unsubscribe, visit settings.