Attention is currently required from: Funkeleinhorn.
1 comment:
Patchset:
Nice to meet you, and thank you for the patch!
Sorry I missed your discussion in IRC (I have relocated to flashrom Discord channel some time ago) but in any case you did the right thing to send the patch! I have a few questions, sorry again if that's something you have discussed on IRC earlier, but I think it's good to have relevant info here on the patch.
1
You are adding the new commands to the documentation, but not to implementation? I understand that it is implemented in the forks you linked. Do you have any plans to add implementation to upstream serprog? That would be so cool!
2
Who decides on the serprog spec, is there a spec somewhere? Basically I want to understand why it's 0x17 and 0x18 and not something else. Can any other number be fine if it's implemented, or is it documented somewhere?
3
Lastly, the question which goes further than this patch!
flashrom is currently in the process of reviewing/updating documentation and converting it to a new format. There are a few serprog docs, and I am asking people who have knowledge of it, to help review the docs. I will do the boring part of converting to a new format and creating the patch, would you agree to be one of the reviewers for the content?
To view, visit change 81428. To unsubscribe, or for help writing mail filters, visit settings.