Nico Huber merged this change.

View Change

Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified Paul Kocialkowski: Looks good to me, approved
edi: Print debug info like others while probing for ENE chips

Instead of just "Probing for ENE KB9012 (EDI), 128 kB:", lets print
some debug info - like it is currently being printed for other chips:

Probing for ENE KB9012 (EDI), 128 kB: edi_chip_probe: hwversion 0xc3, ediid 0x04
Found ENE flash chip "KB9012 (EDI)" (128 kB, SPI) on ch341a_spi.

Change-Id: Id8e62bc9f6785b4bf0be0aaf0f74c8120d77c0d4
Signed-off-by: Mike Banon <mikebdp2@gmail.com>
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Reviewed-on: https://review.coreboot.org/23261
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M edi.c
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/edi.c b/edi.c
index 9397a54..2afd032 100644
--- a/edi.c
+++ b/edi.c
@@ -150,12 +150,18 @@
int rc;

rc = edi_read(flash, ENE_EC_HWVERSION, &hwversion);
- if (rc < 0)
+ if (rc < 0) {
+ msg_cdbg("%s: reading hwversion failed\n", __func__);
return 0;
+ }

rc = edi_read(flash, ENE_EC_EDIID, &ediid);
- if (rc < 0)
+ if (rc < 0) {
+ msg_cdbg("%s: reading ediid failed\n", __func__);
return 0;
+ }
+
+ msg_cdbg("%s: hwversion 0x%02x, ediid 0x%02x\n", __func__, hwversion, ediid);

if (chip->hwversion == hwversion && chip->ediid == ediid)
return 1;

To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8e62bc9f6785b4bf0be0aaf0f74c8120d77c0d4
Gerrit-Change-Number: 23261
Gerrit-PatchSet: 9
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>