2 comments:

File realtek_mst_i2c_spi.c:
- Patch Set #6, Line 429: ret = 0;
  you cannot remove this because now without the 'reset-mcu' param get_params() will fail which isn't […]
  Without 'reset-mcu' now on the following else statement we specifically set ret to 0. It's kind of the program success only if both parameter check are passed so we don't want to mark ret to 0 on the first 'bus' check. Does it make sense?
  Otherwise we need to set ret = SPI_GENERIC_ERROR; before extract_programmer_param("reset-mcu").
- Patch Set #6, Line 453: /* Ensure we are in a known state before entering ISP mode */
  this comment still sort of applies on why there is a pre-amble reset before the spi master gets regi […]
  Done

To view, visit change 45674. To unsubscribe, or for help writing mail filters, visit settings.