Attention is currently required from: Sergii Dmytruk.
9 comments:
Patchset:
A comment to fix the tests
Commit Message:
CLI shares terminal with the rest of the code
What does it mean? I don't understand :(
File dediprog.c:
wow thanks for updating the comment! :)
I will extract this into a separate commit
File dummyflasher.c:
Patch Set #1, Line 58: unsigned long long delay_ns;
This is changing to nano seconds, is it to be able to set a more fine-grained delay?
In the example script, you use `freq=64mhz`, but I think 64mhz would be possible to do even before?
File en29lv640b.c:
Patch Set #1, Line 29: /* chunksize is 2 */
This can also be a separate commit which updates the comment only.
File include/flash.h:
struct stage_progress {
size_t current;
size_t total;
};
And can this go to libflashrom.h , where the struct flashrom_progress is already?
Patch Set #1, Line 587: struct stage_progress stage_progress[FLASHROM_PROGRESS_NR];
Maybe this can go inside `struct flashrom_progress` ? Why do we need two structs on the same level, and they both are about progress. If they have to go together, they better be inside the same struct.
File linux_mtd.c:
Patch Set #1, Line 298: update_progress(flash, FLASHROM_PROGRESS_ERASE, u + data->erasesize, len);
Why you removed this? Should it be
update_progress(flash, FLASHROM_PROGRESS_ERASE, data->erasesize);
File spi.c:
Patch Set #1, Line 118: update_progress(flash, FLASHROM_PROGRESS_READ, start - start_address + to_read, end_address);
Why removing, should this be
update_progress(flash, FLASHROM_PROGRESS_READ, to_read);
To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.