The first fix seems very questionable to me. The inventors of the C language moved to using enums as used in flash.h decades ago. Ref: many parts of Plan 9.
2 comments:
Patch Set #6, Line 146: #define OK FLASHROM_TESTED_OK
What C compiler mandated this? It's poor practice. The people who invented C and the preprocessor, changed their thinking in the 1980s and recommended the use of enums, and even anonymous enums. I'm shocked that a modern C compiler would drive a change like this.
File util/ich_descriptors_tool/ich_descriptors_tool.c:
Patch Set #6, Line 155: struct ich_descriptors desc = { };
if it needs to be zero, and it is an auto, just put an explicit memset. That said, if it needs to be 0, since this is main(), just make it a static to get the same effect. It's main.
To view, visit change 36946. To unsubscribe, or for help writing mail filters, visit settings.