I would drop the added `handle` check, but that's probably a matter of
taste :)

Patch set 4:Code-Review +2

View Change

2 comments:

• File usbdev.c:

  • Patch Set #2, Line 84:

    To follow up, the compiler won't let us do this. […]

    I guess we could cast `filter_by_serial` in the call to
    get_by_vid_pid_filter(). But it won't gain us much...

  • Patch Set #2, Line 105:

    Fair point. […]

    Actually the check makes it more confusing to me. If *nump == 0,
    we want to stop filtering no matter if this is the first or second
    call. One could say that we won't decrement *nump accidentally on
    a call with handle != NULL... but if you think it that far, you
    should already realize that the check is superfluous.

To view, visit change 27444. To unsubscribe, or for help writing mail filters, visit settings.