Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
File mstarddc_spi.c:
Patch Set #1, Line 236: goto out;
This leaves `mstarddc_fd` open.
I have fixed exactly that... but now I see cleanup on error paths is still not ideal (disabling ISP mode is not addressed). I am torn what to do. Fixing all error paths requires a separate patch, and if it should go before this chain that would be the same as happened with stlinkv3. what would you say?
To view, visit change 54033. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0e5f6879bfbfac591a40119ee3e0942a5cbc4b9
Gerrit-Change-Number: 54033
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 17 May 2021 23:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment