Attention is currently required from: David Wu, Kapil Porwal, Maximilian Brune, Nikolai Artemiev, Subrata Banik, Tyler Wang.

View Change

2 comments:

• File flashchips.c:

  • Patch Set #9, Line 6559: FEATURE_WRSR_EXT2

    Umm.. I was refer to funciton spi_prepare_wrsr_ext(): […]

    So the question is between `FEATURE_WRSR_EXT2` and `FEATURE_WRSR2`.
    In reality your next patch CB:79460 needs this, when you get to testing.

    Nikolai maybe you can help us with this? Thank you!

    (I will get back to this after holidays)

  • Patch Set #9, Line 6595: 1695, 1950

    I was reference GD25LQ128E settings. The datasheet says `Full voltage range: 1.65-2. […]

    Okay I see that the other chip has the same range too. Let's leave it for now, but maybe any of other reviewers knows why reducing the voltage range might be needed?

To view, visit change 79088. To unsubscribe, or for help writing mail filters, visit settings.