Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 10: the pointer is null

    I think from the meaning of the patch, you meant to say
    `the pointer is non-null`

• File erasure_layout.c:

  • Patch Set #1, Line 263:

    	old_start_buf = (uint8_t *)malloc(old_start - region_start);
    	if (!old_start_buf) {
    		msg_cerr("Not enough memory!\n");
    		ret = -1;
    		goto _end;
    	}
    	old_end_buf = (uint8_t *)malloc(region_end - old_end);
    	if (!old_end_buf) {
    		msg_cerr("Not enough memory!\n");
    		ret = -1;
    		goto _end;
    	}
    

    Sorry it took longer than I expected. […]

    Great! this is what I was thinking about! I am resolving this comment.
    I added few more other comments though :)

• File erasure_layout.c:

  • Patch Set #2, Line 263: size_t old_start_len

    This can be const, but also

    maybe rename it into `start_buf_len` ?
    I think that "old" suffix doesn't really explain anything. What do you think?

  • Patch Set #2, Line 264: size_t old_end_len

    And this can be const and `end_buf_len`

To view, visit change 81548. To unsubscribe, or for help writing mail filters, visit settings.