Edward O'Callaghan submitted this change.

View Change



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
jedec.c: Collapse erase_block_jedec() indirection

Change-Id: Ia9b539d7fb4a54ba6cc56730e96d35044e291844
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/72501
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M jedec.c
1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/jedec.c b/jedec.c
index 20f2ff3..43ec0df 100644
--- a/jedec.c
+++ b/jedec.c
@@ -313,11 +313,11 @@
return 0;
}

-static int erase_block_jedec_common(struct flashctx *flash, unsigned int block,
- unsigned int blocksize, unsigned int mask)
+int erase_block_jedec(struct flashctx *flash, unsigned int block, unsigned int size)
{
chipaddr bios = flash->virtual_memory;
bool shifted = (flash->chip->feature_bits & FEATURE_ADDR_SHIFTED);
+ const unsigned int mask = getaddrmask(flash->chip);
unsigned int delay_us = 0;

if(flash->chip->probe_timing != TIMING_ZERO)
@@ -529,13 +529,6 @@
return probe_jedec_common(flash, mask);
}

-int erase_block_jedec(struct flashctx *flash, unsigned int page,
- unsigned int size)
-{
- const unsigned int mask = getaddrmask(flash->chip);
- return erase_block_jedec_common(flash, page, size, mask);
-}
-
struct unlockblock {
unsigned int size;
unsigned int count;

To view, visit change 72501. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b539d7fb4a54ba6cc56730e96d35044e291844
Gerrit-Change-Number: 72501
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged