Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File mec1308.c:

  • Patch Set #1, Line 520:

    /* Exit passthru mode before performing commands which do not affect
    	   the SPI ROM */
    	mec1308_exit_passthru_mode(ctx_data);
    
    	/* Re-enable SMI and ACPI.
    	   FIXME: is there an ordering dependency? */
    	if (mbx_write(ctx_data, MEC1308_MBX_CMD, MEC1308_CMD_SMI_ENABLE))
    		msg_pdbg("%s: unable to re-enable SMI\n", __func__);
    	if (mbx_write(ctx_data, MEC1308_MBX_CMD, MEC1308_CMD_ACPI_ENABLE))
    		msg_pdbg("%s: unable to re-enable ACPI\n", __func__);
    

    Could we just call mec1308_shutdown() here? Would have to skip the free() below, though:

        failed_init_cleanup:
                mec1308_shutdown(ctx_data);
                return 1;

        mec1308_init_exit:
                ...

To view, visit change 52597. To unsubscribe, or for help writing mail filters, visit settings.