David Hendricks posted comments on this change.

View Change

Patch set 4:

I forgot to add the region descriptions in ichspi.c, so PS4 adds them. Also, "GbE" is used for consistency (instead of "GBE").

I happen to have a Lewisburg reference board handy, here is the output with PS4: https://paste.flashrom.org/view.php?id=3046

To view, visit change 20922. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b
Gerrit-Change-Number: 20922
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 21 Aug 2017 20:10:35 +0000
Gerrit-HasComments: No