Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Thomas Heijligen.

4 comments:

File include/flash.h:
- Patch Set #6, Line 334: /* special cases must come last. */
  I think this comment better go under FLASHROM_TEST, otherwise it is orphaned in the non-test code. […]
  Done
- Patch Set #6, Line 335:
```
#ifndef FLASHROM_TEST
};
#else
	TEST_ERASE_INJECTOR_1,
	TEST_ERASE_INJECTOR_2,
	TEST_ERASE_INJECTOR_3,
	TEST_ERASE_INJECTOR_4,
	TEST_ERASE_INJECTOR_5,
};

#define NUM_TEST_ERASE_INJECTORS 5
extern erasefunc_t *g_test_erase_injector[NUM_TEST_ERASE_INJECTORS];
#endif
```
  This style is different from the others (read and write), ifndef vs ifdef and I know it saves few li […]
  Yeah, that seems worthwhile. Doubling up the closing braces could probably confuse editors easily. Done.

File tests/erase_func_algo.c:

Patch Set #6, Line 205:
```
			block_erase_chip_1,
			block_erase_chip_2,
			block_erase_chip_3,
			block_erase_chip_4,
			block_erase_chip_5,
```
I think it can help readers, to add per-line comment, since the suffixes (1, 2, 3, 4, 5) do not corr […]
Done

Patch Set #6, Line 649:

			{0xf, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x8, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x9, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0xa, 0x1, TEST_ERASE_INJECTOR_1},
			{0xb, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0xc, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0xd, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0xe, 0x1, TEST_ERASE_INJECTOR_1},
			{0x3, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x4, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x5, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x6, 0x1, TEST_ERASE_INJECTOR_1},
			{0x7, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x0, 0x1, TEST_ERASE_INJECTOR_1}, 
			{0x1, 0x1, TEST_ERASE_INJECTOR_1},

These lines have trailing whitespace (shows as bright pink in gerrit :))

Done

To view, visit change 82251. To unsubscribe, or for help writing mail filters, visit settings.