Attention is currently required from: Anastasia Klimchuk, Nicholas Chin.

View Change

4 comments:

• File ch347_spi.c:

  • Patch Set #7, Line 357: index = 0

    Let's use different variable name, index is already used for indexing the device table. […]

    Done

  • Patch Set #7, Line 365: 30MHz

    I don't mind changing the default if it generally works at 30 MHz. […]

    What is the CH347T device revision that can reproduce this phenomenon?

  • Patch Set #7, Line 365: Invalid SPI speed

    It would be invalid value if you would throw an error and exit, however you do not, but instead cont […]

    Done

  • Patch Set #7, Line 372: clock spi

    "clock spi" is redundant here as clock is already mentioned earlier. […]

    Done

To view, visit change 82776. To unsubscribe, or for help writing mail filters, visit settings.