Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46536 ) Change subject: dummyflasher: fixes on VARIABLE_SIZE chip support ...................................................................... Patch Set 1: (6 comments) https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@7 PS1, Line 7: fixes on VARIABLE_SIZE chip support dummyflasher.c: Fix null par data and size param handling https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@10 PS1, Line 10: (https://review.coreboot.org/c/flashrom/+/44879 Could you use the commit hashes instead of the links like `3149822cd45cb2e5841e15d648783748ba1b2ec6` && `3b8fe0f8e907c0ba9f7c7935e950f3e1538d427f` https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@13 PS1, Line 13: - dummy_init() used to fail for the absence of "size" argument, which broke : the run on non VARIABLE_SIZE emulation target. Now the run fails : without "size" only for VARIABLE_SIZE. Format these with an indent `*`. * dummy_init() should not fail in the absence of the size param as this breaks non-VARIABLE_SIZE emulation functionality. https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@16 PS1, Line 16: - probe_variable_size() used to fail if the bus type is either PARALLEL, LPC or FWH : because flash->mst->par.data is null. Now dummy_init() sets up par_master_dummy.data * probe_variable_size() should fail if bus type is 'PARALLEL, LPC or FWH' however 'flash->mst->par.data' is null. Fix init fn to initialise it. https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@20 PS1, Line 20: - man page is revised to describe how to use VARIABLE_SIZE emulation : target. * Revise man page to describe how to use the VARIABLE_SIZE emulation target. https://review.coreboot.org/c/flashrom/+/46536/1/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/46536/1/flashrom.8.tmpl@658 PS1, Line 658: , which is a power of two. as a power of two. -- To view, visit https://review.coreboot.org/c/flashrom/+/46536 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie6481943a831b946a91b643b4d79e684c27e48b8 Gerrit-Change-Number: 46536 Gerrit-PatchSet: 1 Gerrit-Owner: Namyoon Woo <namyoon@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Lachlan Bishop <lxb@google.com> Gerrit-Reviewer: Namyoon Woo <namyoon@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 19 Oct 2020 01:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment