Attention is currently required from: Nico Huber, Nikolai Artemiev.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 10: preventing confusion
(I only had a quick look at the code, so sorry if I'm off the rails here.) […]
I guess it depends on the meaning of `NT`. I took it as "unknown" which can also include `NA`. Setting `NA` correctly for all the chips would also produce lots of new chip entries. I would specify `NA` where it's well known to have no WP and left "chip unsupported" message for the rest. If you find this problematic, can drop this change.
To view, visit change 68221. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187
Gerrit-Change-Number: 68221
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Thu, 13 Oct 2022 11:55:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment