Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/meson.build:

  • Patch Set #10, Line 32:

      p_data += {
        'testsrc' : p_data.get('testsrc', []),
      }
      srcs += p_data.get('testsrc')
    

    The idea is great, thank you! […]

    Since not every programmer has tests, we would have to define an empty list of testsrc in the programmer definition, but that doesn't make much sense. It's just code that does nothing. Though, we can't iterate over all programmers when the field doesn't exist.

    Thus, line 32-34 add the field testsrc to the programmers data if doesn't exist yet, but depending on if it exists or not it is filled with the existing data or with an empty list. This is needed so that we don't have to define empty lists at every programmer that doesn't have test sources defined yet.

    Line 35 adds the content of testsrc to the list of sources that should be compiled.

To view, visit change 68162. To unsubscribe, or for help writing mail filters, visit settings.