Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: ichspi: Add support for Ice Lake
Technically, it's already supported. Why do we need to do more than
changing the PCI ID?
Apart from adding PCH DID (instead of SPI DID), i don't see ICL support is added, compared to some recent work being done with CB:62783, CB:62282 and CB:62251 for other Intel chipsets.
File chipset_enable.c:
Patch Set #1, Line 2149: 0x34a4
Is the SPI device guaranteed not to be hidden on Ice Lake?
yes, SPI controller is visible on ICL. FAS doesn't specifies any restriction of hiding the SPI controller.
To view, visit change 63584. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If000b152c6e454617a7ad0245d16f8b1dea97fa0
Gerrit-Change-Number: 63584
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment