Jonathon Hall has uploaded this change for review.

View Change

ichspi: Do not attempt to map physical memory for hwseq

ICH hwseq does not need to actually mmap flash, and this fails for
flash chips >16 MB, since only the top 16 MB is mapped into the address
space.

Test: Read and write flash on ICH hwseq with 32 MB flash chip.

Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3
Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
---
M ichspi.c
1 file changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/68090/1
diff --git a/ichspi.c b/ichspi.c
index 7e7967e..aefbe2f 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1794,8 +1794,6 @@
};

static const struct opaque_master opaque_master_ich_hwseq = {
- .map_flash_region = physmap,
- .unmap_flash_region = physunmap,
.max_data_read = 64,
.max_data_write = 64,
.probe = ich_hwseq_probe,

To view, visit change 68090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3
Gerrit-Change-Number: 68090
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-MessageType: newchange