Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.
View Change
1 comment:
Patchset:
Patch Set #6:
One vague idea: interaction with manpage. […]
The first part is a good idea `We could tell people to consider whether information belongs in the manpage or the docs` I will think about it, yes I might try add a sentence or two about it (I need to think a bit).
The second part: good news! :) manpage is already converted to docs! it lives here:
doc/classic_cli_manpage.rst
manpage is generated when docs option is enabled with meson (and it is auto-enabled when sphinx dep is found)
To view, visit change 74225. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752
Gerrit-Change-Number: 74225
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Fri, 12 May 2023 09:33:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment