Attention is currently required from: Neil Armstrong.

Patch set 1:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 9: Technology Limited.

    nit: put this part on the next line (line length limit for commit messages is 72 characters)

• File flashchips.c:

  • Patch Set #1, Line 19242: TEST_UNTESTED

    It would be great to test this flash chip, if you can.

  • Patch Set #1, Line 19253:

    , {
    				.eraseblocks = { {256 * 1024, 1} },
    				.block_erase = spi_block_erase_c7,
    			}
    

    Missing one entry for opcode 0x60:

     }, {
     	.eraseblocks = { {256 * 1024, 1} },
     	.block_erase = spi_block_erase_60,
     }

    Place it before the entry for opcode 0xc7

To view, visit change 50263. To unsubscribe, or for help writing mail filters, visit settings.