Thomas Heijligen submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Thomas Heijligen: Looks good to me, approved
jedec.c: Tidy up whitespace and line wraps

Change-Id: I3f18609709e59cdfc5a853c6e1ae5f53aecacc1a
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/73284
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
---
M jedec.c
1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/jedec.c b/jedec.c
index bb617e0..01c401f 100644
--- a/jedec.c
+++ b/jedec.c
@@ -305,11 +305,11 @@

int erase_sector_jedec(struct flashctx *flash, unsigned int page, unsigned int size)
{
- /* Issue the Sector Erase command */
+ /* Issue the Sector Erase command */
issuecmd(flash, 0x80, 0);
issuecmd(flash, 0x30, page);

- /* wait for Toggle bit ready */
+ /* Wait for Toggle bit ready */
toggle_ready_jedec_slow(flash);

/* FIXME: Check the status register for errors. */
@@ -318,11 +318,11 @@

int erase_block_jedec(struct flashctx *flash, unsigned int block, unsigned int size)
{
- /* Issue the Sector Erase command */
+ /* Issue the Block Erase command */
issuecmd(flash, 0x80, 0);
issuecmd(flash, 0x50, block);

- /* wait for Toggle bit ready */
+ /* Wait for Toggle bit ready */
toggle_ready_jedec_slow(flash);

/* FIXME: Check the status register for errors. */
@@ -333,12 +333,11 @@
int erase_chip_block_jedec(struct flashctx *flash, unsigned int addr, unsigned int blocksize)
{
if ((addr != 0) || (blocksize != flash->chip->total_size * 1024)) {
- msg_cerr("%s called with incorrect arguments\n",
- __func__);
+ msg_cerr("%s called with incorrect arguments\n", __func__);
return -1;
}

- /* Issue the JEDEC Chip Erase command */
+ /* Issue the JEDEC Chip Erase command */
issuecmd(flash, 0x80, 0);
issuecmd(flash, 0x10, 0);


To view, visit change 73284. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f18609709e59cdfc5a853c6e1ae5f53aecacc1a
Gerrit-Change-Number: 73284
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged