Attention is currently required from: Aarya, Nikolai Artemiev, Peter Marheine.
View Change
2 comments:
File flashrom.c:
Patch Set #6, Line 2240: start = region->end + 1;
Just want to double-check: This and all other layout-related occurrences in `layout.c` (like `included_regions_overlap` and `layout_sanity_checks`) don't need to be changed. Is my understanding correct?
File include/layout.h:
To view, visit change 82496. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0ca867aef33b598c2697fc264807fa5e29683ec
Gerrit-Change-Number: 82496
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 27 May 2024 10:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No