Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons.
4 comments:
Patchset:
This looks quite nice now, thank you! […]
In the initial version of this patch the role of unittest.h was that without it ninja test did not build.
My understanding of the whole situation is: with the last changes, test-build environment and real-build environment got closer to each other (closer than they have been before) and now -includes in meson.build are properly covering everything in test-build. So I feel this last patchset is more correct than the first (thanks!).
File meson.build:
Patch Set #6, Line 477: -include
Can we have spaces after -include? That should work, I guess :)
I tried space after -include and it does not work:
cc1: fatal error: stdlib.h: No such file or directory
I checked that command line had this (as expected)
'-include stdlib.h' '-include unittest_env.h'
but it does not build.
File tests/helpers.c:
Patch Set #6, Line 21: #include <stdlib.h>
I'm not sure if we should remove this. The files under tests/ […]
I removed this one because it seems to be not needed?
Yes files in tests/ do not have command line -include
If it is indirectly included in one of the headers above, does it need to be explicitly included again?
File tests/meson.build:
Patch Set #6, Line 38: '-DUNIT_TEST_ENV',
Is this still needed? Now that `unittest_env.h` is only when building […]
Yes you are right: this flag is not needed anymore in this patch. Although I may introduce it in one of the next patches (where I do lots of mocking) but here it is not needed.
To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.