Nico Huber posted comments on this change.

View Change

Patch set 1:

I'll take it as is, do we also want it on staging? As it wouldn't
affect patch compatibility, I don't care.

(1 comment)

• Commit Message:

  • Patch Set #1, Line 11: Convert flashrom to git

    and I thought I did already... :) No, subject of sane length can
    really cover all the topics specifically IMHO.

    Yep, it's hard when you don't focus your commits on specific changes.

    The change converts
    (various aspects of) the build system in form of the makefile and
    getrevision script (to exploit various aspects of git)... which is
    basically what I would expect when a commit of a software projects
    that is known to be using svn contains a subject "Convert flashrom
    to git", don't you?

    Would something like this suit you better?
    Migrate build system to git and add client-side hooks

    No, the hooks I'd expect anyway, I was rather nagging about the
    unrelated changes instead. Though, I don't remember accurately
    what the commit does now and what not. I'm also not sure if we
    still argue about the -U? I've just realized that it's not a
    parent of this commit.

To view, visit change 21886. To unsubscribe, visit settings.