Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
5 comments:
Commit Message:
This is an important step to
remove the global state because it'll allow the programmer's data
to be used in delay functions.
Maybe just drop part of this sentence after 'because' as its not what this patch does specifically f […]
Ack
Programmers that use internal delay can provide NULL as a context.
Move this up to the last paragraph.
Ack
This is one of the steps on the way to move master's data
memory management behind the initialisation API, for more
context see other patches under the same topic specified below.
Drop this paragraph.
Ack
File flashrom.c:
if (!usecs)
return;
if (!programmer->delay)
return internal_delay(flash, usecs); // maybe don't pass context into internal? or pass NULL?
if (!flash) {
msg_perr("%s called but flashctx is not valid!\n"
"Please report a bug at flashrom@flashrom.org\n", __func__);
exit(1);
}
programmer->delay(flash, usecs);
}
leave all this diff out this patch and have it purely just about plumbing flashctx though the control flow graph (CFG) just as is the case in https://review.coreboot.org/c/flashrom/+/67392/
File ichspi.c:
Patch Set #5, Line 860: truct flashctx *flas
Is it maybe sufficient to just use `NULL` in the case of ichspi as it is the internal timer anyway.
To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.