Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Kane Chen, Peter Marheine, Subrata Banik.
View Change
1 comment:
File chipset_enable.c:
Patch Set #6, Line 943:
msg_gdbg("Using libpci PCI_ACCESS_ECAM\n");
#else
pci_acc->method = PCI_ACCESS_I386_TYPE1;
msg_gdbg("Using libpci PCI_ACCESS_I386_TYPE1\n");
nit: This file typically uses msg_pdbg(), could we use that for consistency?
Done
To view, visit change 83896. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4549f87c8b01da0a1d3d8ce0b3b75c1f5fa2cbab
Gerrit-Change-Number: 83896
Gerrit-PatchSet: 7
Gerrit-Owner: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-Attention: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Kane Chen <kane.chen@intel.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 06:27:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>