Attention is currently required from: Felix Singer, Nico Huber.
View Change
1 comment:
File ichspi.c:
Patch Set #7, Line 872: write_cmd = true;
As a reviewer who went through the whole chain, I can say IMO: […]
OK, I have an idea: I'll try to review the retyping patches and I'll comment on variables that should be renamed. Then, you can reply to my comments with a CB: number linking to the change that does the rename.
To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830
Gerrit-Change-Number: 66892
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Wed, 07 Sep 2022 08:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment