Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio.
View Change
1 comment:
Patchset:
Patch Set #1:
In order to keep the code consistent, I think we can drop #2 […]
That's a good observation about using `get_flash_region` with potential shorter end range. I will look closer into this. There is `check_for_unwritable_regions` earlier, however inside it calls `get_flash_region` as well, so same question applies.
I made a note, I will look into this later.
Thank you for your observations! This is really useful.
To view, visit change 79354. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5
Gerrit-Change-Number: 79354
Gerrit-PatchSet: 1
Gerrit-Owner: Carly Zlabek <carlyzlabek@gmail.com>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Vincent Fazio <vfazio@gmail.com>
Gerrit-Attention: Carly Zlabek <carlyzlabek@gmail.com>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Vincent Fazio <vfazio@gmail.com>
Gerrit-Comment-Date: Fri, 08 Dec 2023 01:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Vincent Fazio <vfazio@gmail.com>
Gerrit-MessageType: comment