Attention is currently required from: Miklós Márton, Thomas Heijligen, Angel Pons.

Patch set 12:Code-Review +2

View Change

1 comment:

• File Makefile:

  • Patch Set #11, Line 740:

    # hack to access env variable containing brackets...
    PROGRAMFILES_X86DIR = $(shell env | sed -n "s/^PROGRAMFILES(X86)=//p")
    
    ifneq ($(PROGRAMFILES_X86DIR),)
    ifneq ($(PROGRAMFILES_X86DIR), ${PROGRAMFILES})
    NI845X_LIBS += -L'$(PROGRAMFILES_X86DIR)\National Instruments\NI-845x\MS Visual C'
    NI845X_INCLUDES += -I'$(PROGRAMFILES_X86DIR)\National Instruments\NI-845x\MS Visual C'
    endif
    endif
    

    I've added this. […]

    Looks good, thank you.

To view, visit change 59047. To unsubscribe, or for help writing mail filters, visit settings.