Attention is currently required from: Aarya, Peter Marheine.
View Change
1 comment:
Patchset:
Patch Set #3:
I was for some reasons under impression this change will need to wait until removing makefile... but actually there is no merge conflict!
So this is ready for review.
Also, I think unit tests are adequate testing for this type of change. Please tell me if you disagree.
To view, visit change 83846. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I08fd686fecf6a5313eea2d66b368661c664f4800
Gerrit-Change-Number: 83846
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Fri, 09 Aug 2024 10:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No