View Change

9 comments:

• File dummyflasher.c:

  • Patch Set #1, Line 40: tatic uint8_t *flashchip_contents = NULL;

    more global state here although you could deal with that as a follow up as well since its used sligh […]

    Ack

  • Patch Set #1, Line 56: #if EMULATE_SPI_CHIP

    We probably don't need to do this inside the type definition.

    Done

  • Patch Set #1, Line 68: uint8_t emu_status;

    This could be a follow up, but to move this below 'emu_modified'. […]

    Ack

  • Patch Set #1, Line 175: data->emu_chip = EMULATE_NONE;

    This will trigger undefined behavior if `data` is null. […]

    Done

  • Patch Set #1, Line 467: {

    These braces weren't here before

    Done

  • Patch Set #1, Line 469: }

    braces not needed.

    Done

  • Patch Set #1, Line 542: emu_data

    This was named `data` in `dummy_init`, why use a different name for the same thing here?

    Done

  • Patch Set #1, Line 922: (struct emu_data *)flash->mst->par.data

    For clarity, […]

    Done

  • Patch Set #1, Line 967: const struct emu_data *emu_data = (struct emu_data *)flash->mst->par.data;

    ditto.

    Done

To view, visit change 45230. To unsubscribe, or for help writing mail filters, visit settings.