This is a cool idea and it will help in some cases.
In the past, we had some chip definitions which conflicted with such an approach, though: There was a generic chip entry for one family of chips, and a specific entry for one chip of the family. If we merge this patch, we either need a commit hook checking all possible chip variants for duplicate entries, or a builtin self test which checks for duplicates.

Even better would be not having to hardcode the flash chip name in scripts. What made you hardcode the chip name in the first place, and can we fix that?

View Change

To view, visit change 37723. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iae00bb1108f2d5a0c10977cff63f9348b9fc017f
Gerrit-Change-Number: 37723
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan O'Leary <ryanoleary@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Ryan O'Leary <ryanoleary@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-Comment-Date: Wed, 05 Feb 2020 09:25:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment